Skip to content

Rollup of 5 pull requests #124237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Rollup of 5 pull requests #124237

wants to merge 20 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

gurry and others added 20 commits April 18, 2024 10:15
@gurry
Fix ICE when ADT tail has type error
f83793c
@bvanjoi
cleanup: unnecessary clone during lower generics args
2d5a226
@mati865
Add gnullvm targets to manifest
6ae761c
@BoxyUwU
removal
e1d12ff
@scottmcm
New slice indexing pre-codegen MIR test
5800dc1
@scottmcm
Add a MIR pre-codegen test for Vec::deref
b76faff
@scottmcm
Add a mir-opt test for byte_add on pointers
70df9d9
@scottmcm
Add AggregateKind::RawPtr and enough support to compile
e6b2b76
@scottmcm
Add an intrinsic that lowers to AggregateKind::RawPtr
4f44426
@scottmcm
Use it in the library, and InstSimplify it away in the easy places
de64ff7
@scottmcm
InstSimplify from_raw_parts(p, ()) → p as _
9520ceb
@scottmcm
Also handle AggregateKind::RawPtr in cg_cranelift
5e1d16c
@scottmcm
Address PR feedback
bb8d6f7
@scottmcm
Address more PR feedback
1398fe7
@scottmcm
Update tests after 123949
5e785b1
@matthiaskrgr
Rollup merge of rust-lang#123840 - scottmcm:aggregate-kind-rawptr, r=…
d58b4f0 
…cjgillot

Add an intrinsic for `ptr::from_raw_parts(_mut)`

Fixes rust-lang#123174
cc `@CAD97` `@saethlin`
r? `@cjgillot`

As suggested in rust-lang#123190 (comment), this adds a new `AggregateKind::RawPtr` for creating a pointer from its data pointer and its metadata.

That means that `slice::from_raw_parts` and friends no longer need to hard-code pointer layout into `libcore`, and because it no longer does union hacks the MIR is shorter and more amenable to optimizations.
@matthiaskrgr
Rollup merge of rust-lang#124057 - gurry:124031-ice-layout-errored, r…
5af5493 
…=compiler-errors

Fix ICE when ADT tail has type error

Fixes rust-lang#124031
@matthiaskrgr
Rollup merge of rust-lang#124224 - bvanjoi:cleanup, r=fmease
1737703 
cleanup: unnecessary clone during lower generics args
@matthiaskrgr
Rollup merge of rust-lang#124229 - mati865:add-gnullvm-targets-to-man…
a755d81 
…ifest, r=Mark-Simulacrum

Add gnullvm targets to manifest

Fixes an oversight from rust-lang#121712
@matthiaskrgr
Rollup merge of rust-lang#124231 - BoxyUwU:dereview, r=Mark-Simulacrum
937e9f4 
remove from reviewers

not gonna be around for a few weeks
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 21, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

📌 Commit 937e9f4 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
#16 exporting to docker image format
#16 sending tarball 30.7s done
#16 DONE 42.4s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
##[group]Testing stage2 compiletest suite=crashes mode=crashes (x86_64-unknown-linux-gnu)

running 208 tests
........................................................................................  88/208
.....................................................................................2024-04-21T19:23:41.842323Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
[crashes] tests/crashes/124031.rs ... F
.. 176/208
................................


failures:

---- [crashes] tests/crashes/124031.rs stdout ----

error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/124031.rs' panicked at src/tools/compiletest/src/runtest.rs:2803:9:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:

@matthiaskrgr matthiaskrgr mentioned this pull request Apr 21, 2024
Merged
@matthiaskrgr matthiaskrgr deleted the rollup-mxivafm branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@matthiaskrgr @bors @rust-log-analyzer @rustbot @gurry @bvanjoi @mati865 @BoxyUwU @scottmcm